Skip to content

Allow to pin dependencies#371

Open
darosior wants to merge 5 commits intotpoechtrager:masterfrom
darosior:dependencies_pinning
Open

Allow to pin dependencies#371
darosior wants to merge 5 commits intotpoechtrager:masterfrom
darosior:dependencies_pinning

Conversation

@darosior
Copy link
Copy Markdown
Contributor

The various scripts will at the moment always pull the master branch of each of the projects. This introduces a way to fetch a specific commit per project with minimal changes.

Specifying a specific commit for the project you use is useful for (at least):

  • Pinning a known-working version: a user might not want to unexpectedly have to debug your build if for some reason the latest push on one of the upstream makes an incompatible change.
  • Reproducible builds: it is very unlikely you'd keep having the same binaries if the toolchain you use is a moving target.

It might not be relevant for all project pulled in the scripts (for instance i'm not sure about darling)?

@darosior
Copy link
Copy Markdown
Contributor Author

I wonder if it's not cleaner to pass a new argument to get_sources, the revision, and git checkout there instead of passing commit hashes as branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant